feat: migrate ibc rate limiting #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strides proto naming should be kept as they are the originator of the module. Similar to osmosis tokenfactory. changing proto namespace breaks all upstream tooling and apps and bots. Especially with rust libs |
|
Reverted the query changes @Reecepbcups! |
|
Thanks! I will review this once I talk with the stride team and also get them setup to coordinate. Ill review the diff from my v50 branch & this. I will be a little slow here as I just got back from vacation so might be more so a next week thing FYI |
|
Reviewed and looks good! A few minor things I found in my diff review: Reecepbcups/ratelimitdif#1 but I will handle in another PR. Thank you so so much for this addition! Really appreciate it a ton ❤️ |
Reecepbcups
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the IBC Rate Limiting module built by Stride Labs.
It migrates from @Reecepbcups'
feat/sdk-v50, with a small addition from Noble's team to support app wiring (commit).Closes #188.